RFR: 8294000: Filler array klass should be in jdk/vm/internal, not in java/vm/internal [v2]

Thomas Schatzl tschatzl at openjdk.org
Mon Sep 19 13:49:47 UTC 2022


> Hi all,
> 
>   can I have reviews for the move of the internal filler array klass from `java/vm/internal/` to `jdk/vm/internal` - I noticed that typo in some recent `jmap` dump. All internal klasses are in the `jdk.` package... idk how this slipped through the original change.
> 
> With this change it shows up as
> `   2:           428       13291728  jdk.internal.vm.FillerArray (java.base at 20-internal)`
> which I believe is best.
> 
> Testing: local compilation, checking `jmap` output for instances of this klass directly, the `gc/TestFillerObjectInstantiation.java` jtreg test
> 
> Thanks,
>   Thomas

Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:

  The FillerArrayKlass name passed to create_klass() needs to have `L...;` after all because of JNI which expects klasses to start with certain characters only

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10336/files
  - new: https://git.openjdk.org/jdk/pull/10336/files/9271a8c0..dfe47467

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10336&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10336&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/10336.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10336/head:pull/10336

PR: https://git.openjdk.org/jdk/pull/10336


More information about the hotspot-runtime-dev mailing list