RFR: 8294000: Filler array klass should be in jdk/vm/internal, not in java/vm/internal [v2]

Aleksey Shipilev shade at openjdk.org
Mon Sep 19 16:11:43 UTC 2022


On Mon, 19 Sep 2022 13:49:47 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   can I have reviews for the move of the internal filler array klass from `java/vm/internal/` to `jdk/vm/internal` - I noticed that typo in some recent `jmap` dump. All internal klasses are in the `jdk.` package... idk how this slipped through the original change.
>> 
>> With this change it shows up as
>> `   2:           428       13291728  jdk.internal.vm.FillerArray (java.base at 20-internal)`
>> which I believe is best.
>> 
>> Testing: local compilation, checking `jmap` output for instances of this klass directly, the `gc/TestFillerObjectInstantiation.java` jtreg test
>> 
>> Thanks,
>>   Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   The FillerArrayKlass name passed to create_klass() needs to have `L...;` after all because of JNI which expects klasses to start with certain characters only

Looks fine then!

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10336


More information about the hotspot-runtime-dev mailing list