RFR: 8294197: Zero: JVM_handle_linux_signal should not assume deopt NOPs

Coleen Phillimore coleenp at openjdk.org
Thu Sep 22 12:47:18 UTC 2022


On Thu, 22 Sep 2022 09:45:22 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> This is a simple regression from Loom added code. In `JVM_handle_linux_signal` there is a new block that handles deopt NOPs. Zero does not have them, and so it currently encounters `ShouldNotReachHere()` when entering the block and doing either `os::Posix::ucontext_get_pc(uc)` or `NativeDeoptInstruction::is_deopt_at(pc)`.
> 
> This block should not be entered with Zero at all. 
> 
> Additional testing:
>  - [x] Artificially crashing Linux x86_64 Zero fastdebug now produces a sensible hs_err

Looks good plus trivial.

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10389


More information about the hotspot-runtime-dev mailing list