RFR: 8293873: Centralize the initialization of UL [v2]
Johan Sjölen
jsjolen at openjdk.org
Mon Sep 26 10:23:17 UTC 2022
On Fri, 23 Sep 2022 13:47:05 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix copyright years
>
> src/hotspot/share/logging/logFileStreamOutput.hpp line 77:
>
>> 75: LogStdoutOutput() : LogFileStreamOutput(stdout) {
>> 76: set_config_string("all=warning");
>> 77: }
>
> Since you are here :-)
>
> Wonder whether `_config_string` and `_config_string_buffer_size` could be replaced by an inline `stringStream,` and then we could save the awkward string shuffling in `set_config_string()` and `add_to_config_string()`.
We can do that, but it requires a larger move from buffer pointer + length to outputStream pointers in UL's API:s to be effective.
-------------
PR: https://git.openjdk.org/jdk/pull/10307
More information about the hotspot-runtime-dev
mailing list