RFR: JDK-8294623: gtest does not work with googletest release-1.12.0+

Dingli Zhang dzhang at openjdk.org
Fri Sep 30 08:44:25 UTC 2022


The scope of `GTEST_DECLARE_string_(internal_run_death_test)` has been changed in googletest 1.12.0 [1]. So we can see some new compiler errors as below:


$ bash configure --with-gtest=/home/dingli/jdk-tools/googletest && make run-test TEST="gtest:all"

* For target hotspot_variant-server_libjvm_gtest_objs_gtestMain.o:
In file included from /home/dingli/jdk-tools/googletest/googlemock/include/gmock/internal/gmock-port.h:57,
                 from /home/dingli/jdk-tools/googletest/googlemock/include/gmock/internal/gmock-internal-utils.h:49,
                 from /home/dingli/jdk-tools/googletest/googlemock/include/gmock/gmock-actions.h:145,
                 from /home/dingli/jdk-tools/googletest/googlemock/include/gmock/gmock.h:56,
                 from /home/dingli/jdk/test/hotspot/gtest/unittest.hpp:51,
                 from /home/dingli/jdk/test/hotspot/gtest/gtestMain.cpp:39:

-------------

Commit messages:
 - gtest does not work with googletest release-1.12.0+

Changes: https://git.openjdk.org/jdk/pull/10503/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10503&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8294623
  Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/10503.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10503/head:pull/10503

PR: https://git.openjdk.org/jdk/pull/10503


More information about the hotspot-runtime-dev mailing list