RFR: 8303942: FileMapInfo::write_bytes aborts on a short os::write
David Holmes
dholmes at openjdk.org
Mon Apr 3 09:51:14 UTC 2023
On Mon, 3 Apr 2023 09:13:54 GMT, Afshin Zafari <duke at openjdk.org> wrote:
>> Ah! That is not in the version of the manpage on my system. But the one you link also has:
>>> According to POSIX.1, if count is greater than SSIZE_MAX, the result is implementation-defined; see NOTES for the upper limit on Linux.
>>
>> which explains things. Thanks.
>
> `size` is checked to be `> 0` in loop's condition. Is assert for it still needed?
With the new information an assert that nbytes <= SSIZE_MAX might still be appropriate. Let's see what others think.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13188#discussion_r1155734249
More information about the hotspot-runtime-dev
mailing list