RFR: 8305480: test/hotspot/jtreg/runtime/NMT/VirtualAllocCommitMerge.java failing on 32 bit arm

Tue Apr 4 08:15:05 UTC 2023

On Tue, 4 Apr 2023 07:15:01 GMT, Vladimir Petko <duke at openjdk.org> wrote:

> > There is no reason to losen this test for all platforms, no?
> 
> Fully agree, though not sure how to translate the presence of the `__thumb__` define into test without introducing much complexity. I could only think of a heavy-handed approach of adding a `isCurrentFrameSupported()` to the WhiteBox, but that's probably wrong.

Just limit it to arm32. `if (Platform.isARM())` Thats pragmatic. Otherwise we would have to extend Platform to give us "isThumb" or similar.

Edit: and please add a comment that this is for Thumb's sake.

Cheers, Thomas

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13291#issuecomment-1495533592