RFR: 8303942: FileMapInfo::write_bytes aborts on a short os::write

[Coleen Phillimore]

On Mon, 27 Mar 2023 08:04:23 GMT, Afshin Zafari <duke at openjdk.org> wrote:

> `os::write` is called in a loop until all the requested size is written. The number of bytes parameter(`size_t nbytes`) is casted to `ssize_t size` to be able to check `> 0` condition. To enable pointer arithmetic, the `const void *` is casted to `const char *` for addition and then recasted back.
> 
> ### Test
> local: hotspot:tier1
> mach5 tier1-5

I see so many bugs in the future like the ones we have now because os::write() is assumed to be write_fully, and it's not obvious that you need to call this function 99% of the time.  This way, people need more things to look for in code reviews.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13188#issuecomment-1495896901