RFR: 8274166: Some CDS tests ignore -Dtest.cds.runtime.options [v4]

[Andrey Turbanov]

On Tue, 4 Apr 2023 20:57:14 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> The test.cds.runtime.options property is used to execute the CDS tests in a special mode. E.g., create the archived with G1 but load the archive with EpsilonGC.
>> 
>> Currently tests that are launched with TestCommon.runWithArchive() and CDSTestUtils.runWithArchive() can handle -Dtest.cds.runtime.options. However, some test cases, such as dynamicArchive/HelloDynamic.java, do not call the above two methods, so they ignore -Dtest.cds.runtime.options.
>> 
>> The fix is to move the handling of -Dtest.cds.runtime.options to TestCommon.executeAndLog, because most CDS tests use this function to launch a child JVM. Other considerations are necessary now that the option is exposed to other tests, so checks for GC and CDS are necessary. Verified with tier1-4 tests.
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed indentation and removed unused imports

test/lib/jdk/test/lib/cds/CDSTestUtils.java line 614:

> 612: 
> 613:         // -Xshare options are likely at the end of the args list
> 614:         for (int i  = cmd.size() - 1; i >= 0; i--) {

nit
Suggestion:

        for (int i = cmd.size() - 1; i >= 0; i--) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13273#discussion_r1157783591