RFR: JDK-8305416: runtime/Thread/TestAlwaysPreTouchStacks.java failed with "Did not find expected NMT output"

[David Holmes]

On Wed, 5 Apr 2023 04:46:02 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Fix test. Several issues caused the test to fail intermittently (only on Windows for some reason).
>> 
>> The test starts a a child process with -XX:+AlwaysPreTouchStacks. In this child process, it creates n threads with given stack sizes, then expects them to come up successfully, then checks the final NMT output for the expected stack committed size (which should ideally be very close to the stack reserved size, in contrast to a VM started without -AlwaysPreTouchStacks).
>> 
>> The test had several errors:
>> - the test threads exited, and they were non-daemon threads - therefore, the final NMT report printed during JVM shutdown did not account for the test thread stacks.
>> - The test threads create log output (via Xlog). If that output gets mixed into the final NMT report, the report parser gets confused. This is what happened on Windows, and this made the error intermittent.
>> 
>> ---
>> 
>> The new, fixed test:
>> - creates the test threads as daemon threads and makes them loop endlessly, so they stick around till VM death and show up in the final NMT report. We also create more test threads with noticeably larger stacks for them to have a visible impact on NMT-reported stack sizes.
>> - removed the Xlog output
>> - The test main thread waits until all test threads have successfully started.
>> - I removed the testing of different stack sizes since it was not useful
>> - I made the test stricter: 
>>    - The total committed thread stack size should be more than 3/4ths of the total committed reserved stack size for the test to succeed. This, in combination with large test thread stacks, is enough to prove that PreTouch is working
>>    - I also added a santity test for the total reserved stack size to be larger - but not insanely so - than the combined test thread stack sizes to prove that what we see is caused by our test threads.
>> 
>> Tests: manually ran tests on Windows x64 and Linux x64.
>
> test/hotspot/jtreg/runtime/Thread/TestAlwaysPreTouchStacks.java line 132:
> 
>> 130:                     // as thread stack. But without pre-touching, the thread stacks would be committed to about 1/5th
>> 131:                     // of their reserved size. Requiring them to be committed for over 3/4th shows that pretouch is
>> 132:                     // really working.
> 
> How many platforms have you tested this on?

I tested it on all our platforms and it passed okay.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13295#discussion_r1158045788