RFR: 8305480: test/hotspot/jtreg/runtime/NMT/VirtualAllocCommitMerge.java failing on 32 bit arm [v2]

[Thomas Stuefe]

On Tue, 4 Apr 2023 22:21:06 GMT, Vladimir Petko <duke at openjdk.org> wrote:

>> os::current_frame() is stubbed out on the Linux Arm Thumb platform [1].
>> 
>> This affects 'MemDetailReporter::report_virtual_memory_region()'[2] causing the trace to miss 'from  <location>' part which breaks 'test/hotspot/jtreg/runtime/NMT/VirtualAllocCommitMerge.java'.
>> 
>> 
>> result: Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: '[0x[0]*7947e000 - 0x[0]*794de000] committed 384KB from.*' missing from stdout/stderr
>> 
>> This PR relaxes the test assertion, as 'MemDetailReporter::report_virtual_memory_region()' as 'from' statement is only available if the current frame can be unwinded [2].
>> 
>> [1] https://github.com/openjdk/jdk/blob/0deb648985b018653ccdaf193dc13b3cf21c088a/src/hotspot/os_cpu/linux_arm/os_linux_arm.cpp#L219
>> [2] https://github.com/openjdk/jdk/blob/aa762102e9328ca76663b56b3be6f6141b044744/src/hotspot/share/services/memReporter.cpp#L397
>
> Vladimir Petko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into relax-assertions
>  - review comment: limit change to ARM 32 platform
>  - Relax test assertion
>    
>    MemDetailReporter::report_virtual_memory_region() has two code paths, one containing from and without it, remove from requirement from the assertion

Good! Needs a second review though, even though the patch is trivial, hotspot rules.

@jdksjolen ?

Just noticed, please update the copyright year for Oracle 2022->2023 (leave the rest as it is). No new review needed from me for that.

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13291#pullrequestreview-1372278046
PR Comment: https://git.openjdk.org/jdk/pull/13291#issuecomment-1497021729