RFR: 8305481: gtest is_first_C_frame failing on ARM Thumb [v2]

Thomas Stuefe stuefe at openjdk.org
Thu Apr 6 05:55:07 UTC 2023


On Wed, 5 Apr 2023 02:49:09 GMT, Vladimir Petko <duke at openjdk.org> wrote:

>> os::current_frame() is stubbed out on the Linux Arm Thumb platform [1]
>> This causes gtest 'is_first_C_frame' to fail. 
>> 
>> 
>> [ RUN      ] os.is_first_C_frame_vm
>> ./test/hotspot/gtest/runtime/test_os.cpp:890: Failure
>> Value of: os::is_first_C_frame(&cur_frame)
>>   Actual: true
>> Expected: false
>> [  FAILED  ] os.is_first_C_frame_vm (0 ms)
>> 
>> This pull request disables the test for ARM Thumb.
>> 
>> [1] https://github.com/openjdk/jdk/blob/0deb648985b018653ccdaf193dc13b3cf21c088a/src/hotspot/os_cpu/linux_arm/os_linux_arm.cpp#L219
>
> Vladimir Petko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' into disable_test_on_thumb
>  - disable is_first_C_frame on ARM Thumb

Ok and trivial (meaning you only need one Reviewer).

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13292#pullrequestreview-1374090998


More information about the hotspot-runtime-dev mailing list