RFR: 8274166: Some CDS tests ignore -Dtest.cds.runtime.options [v4]
Matias Saavedra Silva
matsaave at openjdk.org
Thu Apr 6 14:02:27 UTC 2023
On Wed, 5 Apr 2023 01:57:49 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fixed indentation and removed unused imports
>
> A couple of nits but otherwise codewise this seem okay.
>
> Semantically I still think there is a conflict between a test specifying a GC and also using `test.cds.runtime.options` that sets a GC.
Thank you for the reviews @dholmes-ora @iklam and @turbanoff
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13273#issuecomment-1499106019
More information about the hotspot-runtime-dev
mailing list