Integrated: 8274166: Some CDS tests ignore -Dtest.cds.runtime.options

Matias Saavedra Silva matsaave at openjdk.org
Thu Apr 6 14:02:28 UTC 2023


On Fri, 31 Mar 2023 18:20:55 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

> The test.cds.runtime.options property is used to execute the CDS tests in a special mode. E.g., create the archived with G1 but load the archive with EpsilonGC.
> 
> Currently tests that are launched with TestCommon.runWithArchive() and CDSTestUtils.runWithArchive() can handle -Dtest.cds.runtime.options. However, some test cases, such as dynamicArchive/HelloDynamic.java, do not call the above two methods, so they ignore -Dtest.cds.runtime.options.
> 
> The fix is to move the handling of -Dtest.cds.runtime.options to TestCommon.executeAndLog, because most CDS tests use this function to launch a child JVM. Other considerations are necessary now that the option is exposed to other tests, so checks for GC and CDS are necessary. Verified with tier1-4 tests.

This pull request has now been integrated.

Changeset: ce10460e
Author:    Matias Saavedra Silva <matsaave at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/ce10460e94c03f178943fa44dafae18acc480094
Stats:     104 lines in 3 files changed: 73 ins; 29 del; 2 mod

8274166: Some CDS tests ignore -Dtest.cds.runtime.options

Reviewed-by: dholmes, iklam, aturbanov

-------------

PR: https://git.openjdk.org/jdk/pull/13273


More information about the hotspot-runtime-dev mailing list