RFR: 8304738: UnregisteredClassesTable_lock never created [v3]

[David Holmes]

On Thu, 6 Apr 2023 19:30:17 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> UnregisteredClassesTable_lock is never created in mutex_init() and is always nullptr. This lock is referenced in a few places and all of those are effectively thread unsafe. Some of the places `unregistered_classes_table` is accessed are under other locks, so the rank of this lock has to be adjusted appropriately. The lock will be initialized to enable the intended behavior. Verified with tier 1-4 tests.
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Ioi suggestion

A minor suggestion but okay as-is.

Thanks.

src/hotspot/share/classfile/systemDictionaryShared.cpp line 525:

> 523:   }
> 524: 
> 525:   if (Arguments::is_dumping_archive() || ClassListWriter::is_enabled()) {

Nit: is it worth saving the result from line 521 into a local and using it here?

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13358#pullrequestreview-1378389938
PR Review Comment: https://git.openjdk.org/jdk/pull/13358#discussion_r1162258233