RFR: 8303422: Use common functions to exit the VM for -Xshare:dump and CDS errors [v5]

Coleen Phillimore coleenp at openjdk.org
Fri Apr 14 20:59:34 UTC 2023


On Fri, 14 Apr 2023 20:11:23 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> Currently, we have ad-hoc calls to os::_exit(0), vm_exit_during_initialization() and vm_direct_exit() in cases where there are dumptime or runtime errors for CDS. This patch introduces intuitively named methods for exiting the VM when there are dumptime/runtime errors and when dumping is finished. Verified with tier 1-4 tests.
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed logs to match previous output

This looks good with the additional comments above the new functions.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13463#pullrequestreview-1386172925


More information about the hotspot-runtime-dev mailing list