RFR: 8305994: Guarantee eventual async monitor deflation [v2]
ExE Boss
duke at openjdk.org
Sat Apr 15 14:05:33 UTC 2023
On Fri, 14 Apr 2023 14:56:40 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> See discussion in the bug. This PR introduces a safety rail that kicks in when the threshold heuristics fails, and it is cleanly backportable to JDK 17, where the problem manifests as apparent memory leak. There are other options to resolve this (see the bug), but I think this one is the easiest in the interim.
>>
>> Additional testing:
>> - [x] Linux x86_64 `tier1`
>> - [x] Linux x86_64 `tier2`
>> - [x] `runtime/Monitor` tests
>> - [x] Ad-hoc experiments (see example in the bug)
>> - [x] New feature test
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>
> Make the no-progress bit cleaner
test/hotspot/jtreg/runtime/Monitor/GuaranteedAsyncDeflationIntervalTest.java line 26:
> 24: import jdk.test.lib.process.OutputAnalyzer;
> 25: import jdk.test.lib.Platform;
> 26: import jdk.test.lib.process.ProcessTools;
**Nit:** sort imports
Suggestion:
import jdk.test.lib.Platform;
import jdk.test.lib.process.OutputAnalyzer;
import jdk.test.lib.process.ProcessTools;
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13474#discussion_r1167550720
More information about the hotspot-runtime-dev
mailing list