RFR: 8303422: Use common functions to exit the VM for -Xshare:dump and CDS errors [v5]

[Ioi Lam]

On Fri, 14 Apr 2023 20:11:23 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> Currently, we have ad-hoc calls to os::_exit(0), vm_exit_during_initialization() and vm_direct_exit() in cases where there are dumptime or runtime errors for CDS. This patch introduces intuitively named methods for exiting the VM when there are dumptime/runtime errors and when dumping is finished. Verified with tier 1-4 tests.
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed logs to match previous output

Looks good to me. Just one nit.

src/hotspot/share/cds/metaspaceShared.cpp line 920:

> 918: // unrecoverable error.
> 919: void MetaspaceShared::unrecoverable_writing_error(const char* message) {
> 920:   if (message != nullptr) {

For consistency, I think we can add


log_error(cds)("An error has occurred while writing the shared archive file.");

-------------

Marked as reviewed by iklam (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13463#pullrequestreview-1387231956
PR Review Comment: https://git.openjdk.org/jdk/pull/13463#discussion_r1168151661