RFR: 8306057: False arguments calling dispatch_base for aarch64

[Andrew Haley]

On Wed, 22 Feb 2023 03:10:24 GMT, Kick-it11 <duke at openjdk.org> wrote:

> Hi,
>   While I was reading the source codes, I found there might be a bug here.
>    
>   -- In interp_masm_aarch64.cpp, dispatch_base was define as
>               void dispatch_base(TosState state,
>                                               address* table,
>                                               bool verifyoop = true,
>                                               bool generate_poll = false);
> 
>   -- But in dispatch_next of interp_masm_aarch64.cpp,
>      it is called:
>            dispatch_base(state,
>                                    Interpreter::dispatch_table(state),
>                                    generate_poll);

Marked as reviewed by aph (Reviewer).

src/hotspot/cpu/aarch64/interp_masm_aarch64.cpp line 518:

> 516:   // load next bytecode
> 517:   ldrb(rscratch1, Address(pre(rbcp, step)));
> 518:   dispatch_base(state, Interpreter::dispatch_table(state), true, generate_poll);

Suggestion:

  dispatch_base(state, Interpreter::dispatch_table(state), /*verifyoop*/true, generate_poll);


OK with this change. Thanks.

-------------

PR Review: https://git.openjdk.org/jdk/pull/12706#pullrequestreview-1308960081
PR Review Comment: https://git.openjdk.org/jdk/pull/12706#discussion_r1114093894