RFR: 8303276: Secondary assertion failure in AdapterHandlerLibrary::contains during crash reporting

Thomas Stuefe stuefe at openjdk.org
Tue Apr 18 13:17:43 UTC 2023


On Tue, 18 Apr 2023 13:00:33 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> I disagree. In almost all cases of error handling, we should not let a locked check prevent error reporting. Playing whack-a-mole with the locations is not sustainable. And noisy in the code.

I agree with @coleenp. This is a read access from the error handler, where we are guarded against secondary crashes. Disabling the assert means we trade a guaranteed secondary error against a very unlikely one.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13500#issuecomment-1513125731


More information about the hotspot-runtime-dev mailing list