RFR: 8305757: Call Method::compute_has_loops_flag() when creating CDS archive [v3]

[Calvin Cheung]

On Mon, 17 Apr 2023 17:14:03 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> A simple optimization -- call Method::compute_has_loops_flag() for all methods during CDS archive dump. This way, the JIT doesn't need to do this at runtime.
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Move the optimization into MetaspaceShared::try_link_class() where it more naturally belong

Looks good. Just one nit.

src/hotspot/share/oops/instanceKlass.cpp line 2630:

> 2628:   Array<Method*>* methods = this->methods();
> 2629:   for (int index = 0; index < methods->length(); ++index) {
> 2630:     Method *m = methods->at(index);

Suggestion: Method* m = ...

-------------

Marked as reviewed by ccheung (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13390#pullrequestreview-1390529230
PR Review Comment: https://git.openjdk.org/jdk/pull/13390#discussion_r1170304211