RFR: 8305994: Guarantee eventual async monitor deflation [v7]

Daniel D. Daugherty dcubed at openjdk.org
Tue Apr 18 17:11:50 UTC 2023


On Tue, 18 Apr 2023 16:36:34 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> See discussion in the bug. This PR introduces a safety rail that kicks in when the threshold heuristics fails, and it is cleanly backportable to JDK 17, where the problem manifests as apparent memory leak. There are other options to resolve this (see the bug), but I think this one is the easiest in the interim. 
>> 
>> Additional testing:
>>  - [x] Linux x86_64 `tier1`
>>  - [x] Linux x86_64 `tier2`
>>  - [x] `runtime/Monitor` tests
>>  - [x] Ad-hoc experiments (see example in the bug)
>>  - [x] New feature test
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8305994-async-deflate
>  - Build fixes and cleanups
>  - Merge branch 'master' into JDK-8305994-async-deflate
>  - More review comments and improvements
>  - Volker is right again (fixing unsigned underflow)
>  - Sort imports
>  - Volker is right
>  - Make the no-progress bit cleaner
>  - Copyright updates
>  - Touchup the option description
>  - ... and 2 more: https://git.openjdk.org/jdk/compare/0a80ae28...17eb1036

I'm still planning to review this PR, but I haven't gotten to a wide enough spot in the road (yet).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13474#issuecomment-1513517481


More information about the hotspot-runtime-dev mailing list