RFR: 8250269: Replace ATTRIBUTE_ALIGNED with alignas [v15]

[Julian Waters]

On Wed, 12 Apr 2023 01:36:01 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> I've been meaning to review this but have been swamped. Sorry.
> 
> I don't think this change to HotSpot should be combined with JDK-8305341 / PR#13258.
> 
> I'm concerned there might be uses of ATTRIBUTE_ALIGNED in other places than at the front of the declaration (like the fixed offset_of macro in the proposed changes). Obviously there aren't any that break compilation. But is alignas in other places valid but with a different meaning? For a discussion of the kind of thing I'm concerned about, see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108796

I get what you mean, I'll search HotSpot's codebase to see whether this issue pops up in any of our existing code. It's a little tempting to just replace every instance of this macro with alignas, but I guess I'll avoid doing that to keep the changes minimal

-------------

PR Comment: https://git.openjdk.org/jdk/pull/11431#issuecomment-1514230350