RFR: 8305670: Performance regression in LockSupport.unpark with lots of idle threads
Daniel D. Daugherty
dcubed at openjdk.org
Wed Apr 19 17:07:47 UTC 2023
On Tue, 18 Apr 2023 23:19:58 GMT, Andrei Pangin <apangin at openjdk.org> wrote:
>> @dholmes-ora and @robehn - The merge of my (mostly comments) changes with @robehn's
>> "quick_mode" changes are tested and ready for review.
>
> @dcubed-ojdk Thank you for working on this. The changes make total sense to me (I'm not a reviewer though).
> I tested the patch with the `UnparkRegression` benchmark from the bug report and it now produces 151K calls per second comparing to 70K without the patch. That is a quite good improvement.
@apangin - thanks for taking a look at the code. Even as a committer you can chose to
add your review (plus or minus) to a PR. It would still require a (R)eviewer, but I always
count all reviews. Also thanks for the testing!
@robehn - Thanks for the review and thanks for chiming in with replies to @dholmes-ora
queries. I may add more to those threads.
@dholmes-ora - Thanks for the review! I'll start going thru your comments shortly.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13519#issuecomment-1515076970
More information about the hotspot-runtime-dev
mailing list