RFR: JDK-8306462: Remove NMT gtests that test dead-block-printing
Daniel D. Daugherty
dcubed at openjdk.org
Thu Apr 20 17:16:43 UTC 2023
On Wed, 19 Apr 2023 16:05:51 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
> [JDK-8304815](https://bugs.openjdk.org/browse/JDK-8304815) introduced using NMT for more precise hs_err file printing. It came with gtests that test correct live- and dead-block printing.
>
> Live/dead-block printing: given a pointer into or very nearby live/dead malloced block, it tests that the printout identifies that block correctly.
>
> Unfortunately, the dead-block-printing tests are prone to intermittent errors, typically on platforms I don't own and cannot test. These tests are not worth the maintenance burden and should just be removed.
Thumbs up on the technical changes of removing the tests.
However, @dholmes-ora added comment to the bug report that should be
addressed before this integrated:
https://bugs.openjdk.org/browse/JDK-8306462?focusedCommentId=14575199&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14575199
We need to clarify that the fault lies with the new tests and not
the new feature code that was added.
-------------
Marked as reviewed by dcubed (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13539#pullrequestreview-1394445007
More information about the hotspot-runtime-dev
mailing list