RFR: 8305922: [aix,linux] Avoid comparing 'this' to nullptr

Martin Doerr mdoerr at openjdk.org
Thu Apr 20 21:13:48 UTC 2023


On Wed, 12 Apr 2023 18:08:44 GMT, Tyler Steele <tsteele at openjdk.org> wrote:

> This PR removes the remaining 'this' vs. 'nullptr' checks from osThread_linux.cpp and osThread_aix.cpp which cause a build warning on AIX and Linux (when building with Clang). My grepping finds no other occurrences.
> 
> As the warning indicates, `this` cannot be `nullptr` in well-formed C++ code. Previous issues have removed these checks, and I believe it makes sense to do so again in these places.

LGTM.

-------------

Marked as reviewed by mdoerr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13448#pullrequestreview-1383024320


More information about the hotspot-runtime-dev mailing list