RFR: JDK-8306462: Remove NMT gtests that test dead-block-printing
David Holmes
dholmes at openjdk.org
Fri Apr 21 05:48:42 UTC 2023
On Wed, 19 Apr 2023 16:05:51 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
> [JDK-8304815](https://bugs.openjdk.org/browse/JDK-8304815) introduced using NMT for more precise hs_err file printing. It came with gtests that test correct live- and dead-block printing.
>
> Live/dead-block printing: given a pointer into or very nearby live/dead malloced block, it tests that the printout identifies that block correctly.
>
> Unfortunately, the dead-block-printing tests are prone to intermittent errors, typically on platforms I don't own and cannot test. These tests are not worth the maintenance burden and should just be removed.
The test fails because:
const bool b = MemTracker::print_containing_region(p, &ss);
evaluates false when true was expected. But what does that mean? @tsuefe if you can explain what the test expected versus what it found then it may be easier to see why the test is flawed. To me the test seemed fairly straight-forward: create a block, mark it dead, then poke around in it and see if we get what we expected. Thanks.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13539#issuecomment-1517292871
More information about the hotspot-runtime-dev
mailing list