RFR: 8305670: Performance regression in LockSupport.unpark with lots of idle threads [v3]

Fri Apr 21 15:47:48 UTC 2023

On Fri, 21 Apr 2023 04:13:45 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Daniel D. Daugherty has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use optimized logic in Unsafe_Unpark() instead of cv_internal_thread_to_JavaThread().
>
> src/hotspot/share/runtime/globals.hpp line 953:
> 
>> 951:                                                                             \
>> 952:   product(bool, EnableThreadSMRExtraValidityChecks, true, DIAGNOSTIC,       \
>> 953:              "Enable Thread SMR extra validity checks")                     \
> 
> Do you still want to make this change as part of this PR?

Yes I would. All the analysis is recorded in this bug and the PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13519#discussion_r1173925852