RFR: 8305252: make_method_handle_intrinsic may call java code under a lock [v3]

Coleen Phillimore coleenp at openjdk.org
Fri Apr 21 15:56:44 UTC 2023


On Fri, 21 Apr 2023 15:40:32 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix another bug with intrinsic method iteration (need to check for null)
>
> src/hotspot/share/classfile/systemDictionary.cpp line 2000:
> 
>> 1998:                      "Out of space in CodeCache for method handle intrinsic");
>> 1999:     }
>> 2000:   }
> 
> Since the outer conditional doesn't do anything if `HAS_PENDING_EXCEPTION` is true, I think you can combine them in one if statement. 
> `if (throw_error && !HAS_PENDING_EXCEPTION)`

Ok, that sounds reasonable.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13307#discussion_r1173933891


More information about the hotspot-runtime-dev mailing list