RFR: 8304696: Duplicate class names in dynamicArchive tests can lead to test failure [v2]

Calvin Cheung ccheung at openjdk.org
Fri Apr 21 17:35:42 UTC 2023


On Fri, 21 Apr 2023 17:32:37 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> To avoid duplicate class name `MyShutdown`, the fix is to change the `MyShutdown` class name for the LambdaProxyDuringShutdown.java test to `ShutdownHelper`.
>> 
>> Tested manually by running the LInkClassTest.java and LambdaProxyDuringShutdown.java tests serially on linux-x64.
>> Also ran tiers 1 and 3 testing.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @iklam comments

I've made changes to the LinkClassTest.java and LinkClassApp.java as you suggested.
However, I can't make similar changes to the LambdaProxyDuringShutdownApp.java because it will not work with the original intention of the test. In particular:

                // Only the nest host (Outer) and the Inner class are loaded
                // from the dynamic archive.
                // The lambda proxy is not loaded from the dynamic archive.

So I reverted the changes to my original webrev.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13542#issuecomment-1518138713


More information about the hotspot-runtime-dev mailing list