RFR: 8229147: Linux os::create_thread() overcounts guardpage size with newer glibc (>=2.27)

David Holmes dholmes at openjdk.org
Sun Apr 23 02:03:54 UTC 2023


On Fri, 21 Apr 2023 14:04:24 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> We can now detect whether glibc includes the guard pages as part of the requested stack size or not, and so only need to make adjustments when glibc requires it.
>> 
>> The intent was to use a local variable as the "flag" but unfortunately it is also needed in os_posix.cpp so I had to make it part of the os::Linux API.
>> 
>> See bug report (and related) for details.
>> 
>> Testing:
>>   - Manually checked log output for stack sizes and boundaries on systems with and without the glibc fix. (Again see JBS issue)
>>   -  Tiers 1-3 sanity
>> Thanks
>
> I like this, despite the runtime check. AFAIU, this does not affect directly affect RSS, because we don't commit guard pages?

Before I forget, Thanks for looking at this @shipilev , @TheRealMDoerr  and @tstuefe  :)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13571#issuecomment-1518918823


More information about the hotspot-runtime-dev mailing list