RFR: 8229147: Linux os::create_thread() overcounts guardpage size with newer glibc (>=2.27)

[Thomas Stuefe]

On Sun, 23 Apr 2023 01:55:02 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> src/hotspot/os/linux/os_linux.cpp line 4549:
>> 
>>> 4547: 
>>> 4548:   // Check if we need to adjust the stack size for glibc guard pages.
>>> 4549:   init_adjust_stack_for_guard_pages();
>> 
>> Please make this glibc only. I agree with @TheRealMDoerr, muslc does not have `__pthread_get_minstack`, no need to pay for a dynamic lookup that will always fail.
>
> To a degree this is pre-existing behaviour - nothing to do with `AdjustStackSizeForTLS` is glibc-only even though it is. So I would have to change that as well, which broadens the scope and is not something I can, or want to, test!

Okay, up to you then. We can fix this in a cleanup for muslc later.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13571#discussion_r1174929672