RFR: 8229147: Linux os::create_thread() overcounts guardpage size with newer glibc (>=2.27)

Thomas Stuefe stuefe at openjdk.org
Mon Apr 24 08:14:44 UTC 2023


On Sun, 23 Apr 2023 01:46:47 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> src/hotspot/os/linux/os_linux.cpp line 1029:
>> 
>>> 1027:                        ", stack: " PTR_FORMAT " - " PTR_FORMAT " (" SIZE_FORMAT "k) ).",
>>> 1028:                        os::current_thread_id(), (uintx) pthread_self(),
>>> 1029:                        p2i(thread->stack_base()), p2i(thread->stack_end()), thread->stack_size() / K);
>> 
>> Separate fix maybe, to make back porting simpler?
>
> How does this have any affect on backporting?

It is both  cleaner and easier to handle to fix just one problem per patch.This is a separate issue. Since this misprint here is a bug introduced with [JDK-8290067](https://bugs.openjdk.org/browse/JDK-8290067), which is in 17, we probably want to downport this tiny fix. No clue if and when and to what release we want to downport JDK-8229147.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13571#discussion_r1174933525


More information about the hotspot-runtime-dev mailing list