RFR: 8306774: Make runtime/Monitor/GuaranteedAsyncDeflationIntervalTest.java more reliable [v2]
Daniel D. Daugherty
dcubed at openjdk.org
Tue Apr 25 20:41:08 UTC 2023
On Tue, 25 Apr 2023 16:16:54 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> > LGTM. Why did you steer away from the i-hash solution though, I thought that was rather neat.
>
> Previous version of this PR used the take-IHC-while-locked trick to inflate the monitors, but I figured it would not work after [JDK-8291555: Implement alternative fast-locking scheme](https://bugs.openjdk.org/browse/JDK-8291555) is here, and would quite probably be even less reliable as Lilliput progresses towards off-side IHC table.
Hmmm... I don't remember seeing anything in JDK-8291555 that would break the
take-IHC-while-locked trick. I use that trick in some of my monitor stress tests...
It would be sad to see that go away...
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13634#issuecomment-1522385050
More information about the hotspot-runtime-dev
mailing list