RFR: 8306774: Make runtime/Monitor/GuaranteedAsyncDeflationIntervalTest.java more reliable [v3]

[Aleksey Shipilev]

On Wed, 26 Apr 2023 08:17:59 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> As seen in some CI runs, doing `Object.wait(1)` to inflate 10K monitors can take quite a while. One of the test cases implicitly relies on threshold heuristics kicking in before the guaranteed interval of 5 seconds expires. Even if we wait for 1ms for each `wait` call, we only inflate 5K monitors in those 5 seconds. Which is okay for 5s and 10% threshold test, which would fire after about 1K monitors inflated. But we can also stall for longer -- because `wait(1)` is not guaranteed to return in 1ms, subject to locking granularity -- which means we can inflate less that 1K monitors, which would mean the threshold heuristics would not fire.
>> 
>> This fix strengthens the test in two ways: 
>>   1. Uses multiple threads to inflate the monitors, so that we are able to eat the cost of `wait(1)`.
>>   2. Drops the threshold heuristics threshold to minimum value to increase the chances of it firing.
>> 
>> This also makes the test faster.
>> 
>> @dcubed-ojdk, you might want to run this through your CI to see if it fixes the test troubles.
>> 
>> Additional testing:
>>  - [x] Ad-hoc runs of the test, 100 iterations without trouble.
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8306774-async-test
>  - Drop redundant field
>  - Parallel inflation instead of relying on hashCode
>  - Drop MUDT to 1 to increase the chances
>  - Fix

Local testing looks good. GHAs look good. I am integrating now.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13634#issuecomment-1523238184