RFR: JDK-8306883: Thread stacksize is reported with wrong units in os::create_thread logging

Aleksey Shipilev shade at openjdk.org
Wed Apr 26 15:39:02 UTC 2023


On Wed, 26 Apr 2023 05:54:18 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> Trivial fix to the display of the thread stack size when UL-logging thread attach.
> 
> Before:
> `[0.012s][info][os,thread] Thread attached (tid: 153734, pthread id: 139862746482432, stack: 0x00007f3455525000 - 0x00007f3455424000 (1052672k) ).`
> 
> Now:
> `[0.002s][info][os,thread] Thread attached (tid: 350868, pthread id: 140394443233024, stack: 0x00007fb020eae000 - 0x00007fb020dad000 (1028k) ).`

To be overly nerdy here, "k" is the SI prefix which signifies 1000, while "K" is 1024. So the message should also be with upper-case "K", I think :) Otherwise looks good.

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13665#pullrequestreview-1402255016


More information about the hotspot-runtime-dev mailing list