RFR: JDK-8305416: runtime/Thread/TestAlwaysPreTouchStacks.java failed with "Did not find expected NMT output" [v2]

Gerard Ziemski gziemski at openjdk.org
Wed Apr 26 19:35:24 UTC 2023


On Wed, 26 Apr 2023 18:46:51 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> I'm not sure what you mean? This test tests that if I start a VM with `-XX:+AlwaysPreTouchThreadStacks` the VM will touch all - or most - of the thread stacks upon thread start. It exploits that NMT actually probes the thread stacks for committed pages, and checks what NMT says about thread stacks.
> 
> I would not know how to do this in gtest, espectially since forking is involved.

Sorry, I saw `AlwaysPreTouchThreadStacks`, but read `AlwaysPreTouch`.

Looks good to me.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13295#discussion_r1178297513


More information about the hotspot-runtime-dev mailing list