Integrated: 8229147: Linux os::create_thread() overcounts guardpage size with newer glibc (>=2.27)
David Holmes
dholmes at openjdk.org
Wed Apr 26 23:02:58 UTC 2023
On Fri, 21 Apr 2023 04:57:28 GMT, David Holmes <dholmes at openjdk.org> wrote:
> We can now detect whether glibc includes the guard pages as part of the requested stack size or not, and so only need to make adjustments when glibc requires it.
>
> The intent was to use a local variable as the "flag" but unfortunately it is also needed in os_posix.cpp so I had to make it part of the os::Linux API.
>
> See bug report (and related) for details.
>
> Testing:
> - Manually checked log output for stack sizes and boundaries on systems with and without the glibc fix. (Again see JBS issue)
> - Tiers 1-3 sanity
> Thanks
This pull request has now been integrated.
Changeset: 9ebcda21
Author: David Holmes <dholmes at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/9ebcda2165c42e3f7b82a9ae8074badb69c0d270
Stats: 86 lines in 3 files changed: 49 ins; 20 del; 17 mod
8229147: Linux os::create_thread() overcounts guardpage size with newer glibc (>=2.27)
Reviewed-by: shade, stuefe
-------------
PR: https://git.openjdk.org/jdk/pull/13571
More information about the hotspot-runtime-dev
mailing list