RFR: JDK-8305507 Add support for grace period before AbortVMOnSafepointTimeout triggers

[David Holmes]

On Fri, 7 Apr 2023 11:20:27 GMT, Wojciech Kudla <duke at openjdk.org> wrote:

> As described https://bugs.openjdk.org/browse/JDK-8305507 this change adds a grace period before AbortVMOnSafepointTimeout activates to allow for JVM warm-up to conclude

The request seems reasonable to accommodate, but please see below.

Please add a new testcase for this to test/hotspot/jtreg/runtime/Safepoint/TestAbortVMOnSafepointTimeout.java

Thanks

src/hotspot/share/runtime/safepoint.cpp line 788:

> 786:   // To debug the long safepoint, specify both AbortVMOnSafepointTimeout &
> 787:   // ShowMessageBoxOnError.
> 788:   if (AbortVMOnSafepointTimeout && Management::ticks_to_ms(os::elapsed_counter()) > (jlong)AbortVMOnSafepointTimeoutDelay) {

Rather than use the Management API here perhaps just:

if (AbortVMOnSafepointTimeout
    && (os::elapsedTime() * MILLIUNITS > AbortVMOnSafepointTimeoutDelay)) {

?

-------------

Changes requested by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13386#pullrequestreview-1403286797
PR Review Comment: https://git.openjdk.org/jdk/pull/13386#discussion_r1178683653