RFR: 8305819: LogConfigurationTest intermittently fails on AArch64

David Holmes dholmes at openjdk.org
Thu Apr 27 07:38:25 UTC 2023


On Thu, 27 Apr 2023 06:57:51 GMT, gaogao-mem <duke at openjdk.org> wrote:

>> Is the solution as simple as the test needing to use the ConfigurationLock?
>
> @dholmes-ora Thank you for your comment. I agree with your opinion that the API here needs better design and implementation. In my humble opinion, if we need to use locks, I would prefer to use a readwrite lock. Personally, I lean towards a lock-free implementation, but as a beginner, I'm not fully familiar with the overall design and implementation of the UL, so it may require more time. The current crash can be resolved with this patch, so I think maybe we can first apply this patch to solve the problem we are facing now. If possible, I'm willing to propose a more thorough solution in a follow up patch, but it may take some time.

@gaogao-mem Sorry but I have strong objections to this patch. I suspect the gtest is using the UL API incorrectly. There is a lock that guards configuration changes, that is already part of the design. I will try to take a more detailed look tomorrow

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13421#issuecomment-1524956955


More information about the hotspot-runtime-dev mailing list