RFR: JDK-8306696: Remove MetaspaceReclaimPolicy=aggressive and deprecate MetaspaceReclaimPolicy [v2]

[Thomas Stuefe]

On Thu, 27 Apr 2023 07:11:42 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   continue to accept flag
>
> src/hotspot/share/runtime/arguments.cpp line 507:
> 
>> 505:   { "RequireSharedSpaces",          JDK_Version::jdk(18), JDK_Version::jdk(19), JDK_Version::undefined() },
>> 506:   { "UseSharedSpaces",              JDK_Version::jdk(18), JDK_Version::jdk(19), JDK_Version::undefined() },
>> 507:   { "MetaspaceReclaimPolicy",       JDK_Version::jdk(21), JDK_Version::undefined(), JDK_Version::undefined() },
> 
> What you have done isn't deprecation, it is obsoletion - the flag is accepted but completely ignored (which is fine by me for a diagnostic flag). The above should be changed accordingly, or else continue to parse the flag and check for a valid value.

You are right.

I don't want to deprecate right now since the flag was made a diagnostic flag just recently. I will continue to parse the flag, but do we really still need to parse for valid values? The flag has no meaning anymore.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13597#discussion_r1178767586