RFR: 8306825: Monitor deflation might be accidentally disabled by zero intervals [v2]
Aleksey Shipilev
shade at openjdk.org
Thu Apr 27 09:19:54 UTC 2023
On Wed, 26 Apr 2023 20:11:26 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Drop unneccessary options
>
> test/hotspot/jtreg/runtime/Monitor/DeflationIntervalsTest.java line 174:
>
>> 172: "-XX:GuaranteedAsyncDeflationInterval=0",
>> 173: "-XX:AsyncDeflationInterval=0",
>> 174: "-XX:MonitorUsedDeflationThreshold=0",
>
> But... this one isn't an interval option...
Right. Dropped! Has no effect on the test outcome.
> test/hotspot/jtreg/runtime/Monitor/DeflationIntervalsTest.java line 182:
>
>> 180: // Try with all heuristics thresholds at zero
>> 181: test(Disabled.NO, Guaranteed.NO, Threshold.NO,
>> 182: "-XX:GuaranteedAsyncDeflationInterval=0",
>
> But... this one isn't a threshold option...
Right, dropped. Now we have `Guaranteed.MAYBE` on that path :)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13635#discussion_r1178833016
PR Review Comment: https://git.openjdk.org/jdk/pull/13635#discussion_r1178833378
More information about the hotspot-runtime-dev
mailing list