RFR: JDK-8306696: Remove MetaspaceReclaimPolicy=aggressive and deprecate MetaspaceReclaimPolicy [v4]

Thomas Stuefe stuefe at openjdk.org
Thu Apr 27 10:26:24 UTC 2023


> The diagnostic setting MetaspaceReclaimPolicy=aggressive is very rarely used, and I would like to remove it. This is a part of a larger effort to simplify metaspace coding and cut down on testing time, in preparation for upcoming changes to Metaspace with Lilliput.
> 
> MetaspaceReclaimPolicy had recently been demoted from an official to a diagnostic switch (see CSR [JDK-8302130](https://bugs.openjdk.org/browse/JDK-8302130)). See also the CSR text for a more in-depth explanation of what this switch does, its history, and why it could be removed for good.
> 
> The switch has not that much impact on RSS reduction but has the side effect of increasing VMA fragmentation compared to the default setting since it reduces the size of metaspace commit granules from 64K to 16K. The settings used by default (MetaspaceReclaimPolicy=balanced) are proven now in the field and can be used without alternatives (since any alternative has to be tested).
> 
> Since this would remove the last valid value for MetaspaceReclaimPolicy apart from its default "balanced" value, it makes sense to deprecate MetaspaceReclaimPolicy at the same time.
> 
> This allows us to cut down on Metaspace testing quite a bit since it removes one permutation from the test set.

Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Merge branch 'master' into JDK-8306696-remove-MetaspaceReclaimPolicy-aggressive
 - remove accidentally added test
 - fix-tabs
 - continue to accept flag
 - start

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/13597/files
  - new: https://git.openjdk.org/jdk/pull/13597/files/941f7c01..6233cd1c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=13597&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13597&range=02-03

  Stats: 36819 lines in 622 files changed: 24430 ins; 8775 del; 3614 mod
  Patch: https://git.openjdk.org/jdk/pull/13597.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13597/head:pull/13597

PR: https://git.openjdk.org/jdk/pull/13597


More information about the hotspot-runtime-dev mailing list