RFR: 8305670: Performance regression in LockSupport.unpark with lots of idle threads [v4]

[Daniel D. Daugherty]

On Thu, 27 Apr 2023 02:06:35 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Daniel D. Daugherty has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8305670.with-rehn-quick-mode.cr3.patch
>
> src/hotspot/share/runtime/javaThread.cpp line 744:
> 
>> 742:   // allows the join() to complete once we've done the notify_all() below.
>> 743:   // Needs a release() to obey Java Memory Model requirements (which is done
>> 744:   // in set_thread()).
> 
> With the suggested renaming you don't need to add comments like this.

Most of the comment isn't mine; I just updated it slightly and reformatted it. Is the
mention of "Java Memory Model requirements" not a useful thing to note here?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13519#discussion_r1179414077