RFR: 8306950: [REDO] JDK-8305252 make_method_handle_intrinsic may call java code under a lock [v3]
Coleen Phillimore
coleenp at openjdk.org
Thu Apr 27 18:45:59 UTC 2023
On Thu, 27 Apr 2023 18:19:35 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Matias improvement
>
> src/hotspot/share/classfile/systemDictionary.cpp line 1953:
>
>> 1951: {
>> 1952: MonitorLocker ml(THREAD, InvokeMethodIntrinsicTable_lock);
>> 1953: while (true) {
>
> Given that you break out of this loop based on the state of `created`, it might be better to change the loop to `while(!created)`.
I agree, that does look better. Thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13681#discussion_r1179548151
More information about the hotspot-runtime-dev
mailing list