RFR: 8306950: [REDO] JDK-8305252 make_method_handle_intrinsic may call java code under a lock [v3]

[David Holmes]

On Thu, 27 Apr 2023 18:58:41 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Matias improvement
>
> src/hotspot/share/classfile/systemDictionary.cpp line 1957:
> 
>> 1955:     while (!created) {
>> 1956:       met = _invoke_method_intrinsic_table.put_if_absent(key, &created);
>> 1957:       if (met != nullptr && *met != nullptr) {
> 
> met cannot be null. I think it should be changed to `assert(met != nullptr, ...)`

Good catch

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13681#discussion_r1179959781