RFR: 8306950: [REDO] JDK-8305252 make_method_handle_intrinsic may call java code under a lock [v5]
Coleen Phillimore
coleenp at openjdk.org
Fri Apr 28 12:21:26 UTC 2023
On Fri, 28 Apr 2023 05:57:29 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> I agree, that does look better. Thanks!
>
> No it doesn't! Sorry but there are two reasons for getting out of the loop - one involves a return and one involves the break - only putting one of those in the loop condition doesn't clarify anything IMO.
So I have 4 reviewers and 3 different opinions, on something that people's eyes differ on but are the same thing.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13681#discussion_r1180328453
More information about the hotspot-runtime-dev
mailing list