RFR: 8306950: [REDO] JDK-8305252 make_method_handle_intrinsic may call java code under a lock [v5]

Coleen Phillimore coleenp at openjdk.org
Fri Apr 28 12:22:53 UTC 2023


On Fri, 28 Apr 2023 03:50:57 GMT, ExE Boss <duke at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Ioi noticed that met can never be null after put-if-absent.
>
> src/hotspot/share/classfile/systemDictionary.cpp line 1955:
> 
>> 1953:     bool created = false;
>> 1954:     // Loop until the current thread won the race and will try to create the full entry.
>> 1955:     while (!created) {
> 
> Maybe instead use:
> 
> do { ... } while (!created);

There's another variation of the same code.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13681#discussion_r1180328796


More information about the hotspot-runtime-dev mailing list