RFR: 8309240: Array classes should be stored in dynamic CDS archive [v4]

[Calvin Cheung]

On Mon, 31 Jul 2023 19:22:20 GMT, Ashutosh Mehra <duke at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   comments from Ioi and David
>
> src/hotspot/share/cds/dynamicArchive.cpp line 418:
> 
>> 416:     for (int i = 0; i < num_array_klasses; i++) {
>> 417:       ObjArrayKlass* oak = _array_klasses->at(i);
>> 418:       _dynamic_archive_array_klasses->at_put(i, oak);
> 
> Isn't storing `oak` in the array  covered by the next call to `write_pointer_in_buffer`?

Thanks for your review. The `write_pointer_in_buffer` writes the buffered address of `oak` to the array. So the `at_put` call isn't necessary.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14959#discussion_r1280110216