RFR: 8309240: Array classes should be stored in dynamic CDS archive [v5]

[Calvin Cheung]

On Tue, 1 Aug 2023 15:08:23 GMT, Ashutosh Mehra <duke at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>> 
>>  - Merge branch 'master' into 8309240-array-classes-dynamic-cds
>>  - comments from Ioi and David
>>  - @iklam comments
>>  - simplify the fix
>>  - 8309240: Array classes should be stored in dynamic CDS archive
>
> src/hotspot/share/classfile/systemDictionaryShared.cpp line 193:
> 
>> 191:     assert(!k->is_shared(), "sanity");
>> 192:   } else {
>> 193:     assert(DynamicDumpSharedSpaces, "sanity");
> 
> I am trying to understand this block of code. Does it imply `k` can be a shared class when `DynamicDumpSharedSpaces` is set?  When can this happen? 
> If `k` can be a shared class here, then the assert in the next call to `DumpTimeClassInfo::get_info` for `k` to be a non-shared class will be triggered. So there seem to be some inconsistency in the asserts, unless I am reading it wrong.

It turns out those changes are not needed; they are probably leftover code from an early prototype.
I also reverted the change in `SystemDictionaryShared::is_excluded_class`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14959#discussion_r1280938474